[book-store] Simplify example.py #2175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing example.py is quite complex and not particulary efficient, even for quite small lists of books. This example.py is much simpler, but could be made considerably more efficient through a bit of a caching and some sensible short-circuit returns. These are left to the student to figure out, however.
cmccandless
approved these changes
Feb 20, 2020
ErikSchierboom
pushed a commit
to ErikSchierboom/python
that referenced
this pull request
Jan 21, 2021
…sm#2847) * Add new concept exercise - string methods * Fix formatting * Use prettier to clean up markdown * Resolve PR comments * Fix closing bracket * PR comment, add concept files * Update languages/exercises/concept/string-methods/.meta/design.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/exercises/concept/string-methods/.docs/introduction.md Co-authored-by: Olivia Kim <[email protected]> Co-authored-by: BethanyG <[email protected]>
ErikSchierboom
pushed a commit
to ErikSchierboom/python
that referenced
this pull request
Jan 22, 2021
…sm#2847) * Add new concept exercise - string methods * Fix formatting * Use prettier to clean up markdown * Resolve PR comments * Fix closing bracket * PR comment, add concept files * Update languages/exercises/concept/string-methods/.meta/design.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/exercises/concept/string-methods/.docs/introduction.md Co-authored-by: Olivia Kim <[email protected]> Co-authored-by: BethanyG <[email protected]>
ErikSchierboom
pushed a commit
to ErikSchierboom/python
that referenced
this pull request
Jan 26, 2021
…sm#2847) * Add new concept exercise - string methods * Fix formatting * Use prettier to clean up markdown * Resolve PR comments * Fix closing bracket * PR comment, add concept files * Update languages/exercises/concept/string-methods/.meta/design.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/exercises/concept/string-methods/.docs/introduction.md Co-authored-by: Olivia Kim <[email protected]> Co-authored-by: BethanyG <[email protected]>
ErikSchierboom
pushed a commit
to ErikSchierboom/python
that referenced
this pull request
Jan 27, 2021
…sm#2847) * Add new concept exercise - string methods * Fix formatting * Use prettier to clean up markdown * Resolve PR comments * Fix closing bracket * PR comment, add concept files * Update languages/exercises/concept/string-methods/.meta/design.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/exercises/concept/string-methods/.docs/introduction.md Co-authored-by: Olivia Kim <[email protected]> Co-authored-by: BethanyG <[email protected]>
ErikSchierboom
pushed a commit
to ErikSchierboom/python
that referenced
this pull request
Jan 29, 2021
* Add new concept exercise - string methods * Fix formatting * Use prettier to clean up markdown * Resolve PR comments * Fix closing bracket * PR comment, add concept files * Update languages/exercises/concept/string-methods/.meta/design.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/exercises/concept/string-methods/.docs/introduction.md Co-authored-by: Olivia Kim <[email protected]> Co-authored-by: BethanyG <[email protected]>
ErikSchierboom
pushed a commit
to ErikSchierboom/python
that referenced
this pull request
Jan 29, 2021
* Add new concept exercise - string methods * Fix formatting * Use prettier to clean up markdown * Resolve PR comments * Fix closing bracket * PR comment, add concept files * Update languages/exercises/concept/string-methods/.meta/design.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/exercises/concept/string-methods/.docs/introduction.md Co-authored-by: Olivia Kim <[email protected]> Co-authored-by: BethanyG <[email protected]>
cmccandless
pushed a commit
that referenced
this pull request
Jan 29, 2021
* Add new concept exercise - string methods * Fix formatting * Use prettier to clean up markdown * Resolve PR comments * Fix closing bracket * PR comment, add concept files * Update languages/exercises/concept/string-methods/.meta/design.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/concepts/string-methods/about.md * Update languages/exercises/concept/string-methods/.docs/introduction.md Co-authored-by: Olivia Kim <[email protected]> Co-authored-by: BethanyG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing example.py is quite complex and not particulary efficient,
even for quite small lists of books. This example.py is much simpler,
but could be made considerably more efficient through a bit of a caching
and some sensible short-circuit returns. These are left to the student
to figure out, however.
This one will also pass the new tests in #2174.